fix(ci): inline cancel-on-failure to fix workflow status shown as skipped#7521
Merged
manusa merged 1 commit intofabric8io:mainfrom Mar 5, 2026
Merged
Conversation
…pped The separate cancel-on-failure job introduced in fabric8io#7475 is skipped when the main job succeeds, causing GitHub to mark the entire workflow as "skipped" in the UI. Moving the cancellation into a step within the main job avoids this since steps with `if: failure()` are silently skipped without affecting the overall workflow status. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Marc Nuri <marc@marcnuri.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cancel-on-failurejob introduced in chore(ci): cancel PR workflows when prerequisite checks fail #7475 gets skipped on success, which causes GitHub to mark the entire workflow as "skipped"if: failure()steps are silently skipped without affecting the overall workflow conclusion